Repository navigation
feat: accept CCCO fixpack 1.2.2.3 - #212
Merged
Merged
Conversation
- Add 1.2.2.3 to the CCCO versions listed in docs/README.md - Cover fixpack 1.2.2.3 in TestProcess_CCCO_ValidCertVersion - Requires contract-go v3.5.0 (already in go.mod), which adds 1.2.2.3
ANJANA-A-R-K
requested review from
Rohit-Singh43-1,
Sashwat-K and
vikas-sharma24
November 12, 2026 06:47
vikas-sharma24
approved these changes
Nov 12, 2026
Sashwat-K
approved these changes
Nov 12, 2026
Rohit-Singh43-1
approved these changes
Nov 12, 2026
| // TestProcess_CCCO_ValidCertVersion tests that declared CCCO mod releases and fixpacks are accepted | ||
| func TestProcess_CCCO_ValidCertVersion(t *testing.T) { | ||
| for _, version := range []string{"1.2.2", "1.2.2.1", "1.2.1"} { | ||
| for _, version := range []string{"1.2.2", "1.2.2.1", "1.2.2.3", "1.2.1"} { |
Member
There was a problem hiding this comment.
Thanks @ANJANA-A-R-K for changes , Just for my understanding should be mentioned 1.2.2.2 fix pack as well in this array ?
Contributor
|
🎉 This PR is included in version 1.48.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Fixes #
Type of Change
Target Platform
Testing
make testpassesmake fmtapplied (no formatting changes needed)Checklist
make test)